Repository navigation
fix: multiget an @ literally where Robur needs it - #861
Merged
Merged
Conversation
This was referenced Nov 12, 2026
tobixen
force-pushed
the
fix/robur-encoded-href
branch
from
November 12, 2026 21:13
83e3d15 to
ec13dce
Compare
Robur decodes %40 in a request path but not in an href inside a REPORT body: a calendar-multiget naming .../x%40y.ics answers 404 for an object a GET of that URL serves, and .../x@y.ics finds it. The new hint url.encode-at.encoded.href records that, and where it is unsupported the @ of a multiget href is sent literally. Other escapes are kept, and a server declaring the spellings distinct is left alone. Prompt: Continue working on getting those [calendaring] conformance tests passing. [on Robur, every object with an @ in its UID failed its read-back] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
fix/robur-encoded-href
branch
from
November 12, 2026 23:15
ec13dce to
670a256
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Robur decodes %40 in a request path but not in an href inside a REPORT
body: a calendar-multiget naming .../x%40y.ics answers 404 for an
object a GET of that URL serves, and .../x@y.ics finds it. The new
hint url.encode-at.encoded.href records that, and where it is
unsupported the @ of a multiget href is sent literally. Other escapes
are kept, and a server declaring the spellings distinct is left alone.
Prompt: Continue working on getting those [calendaring] conformance tests passing. [on Robur, every object with an @ in its UID failed its read-back]
Assisted-By: Claude Opus 5.5 noreply@anthropic.com
The matching caldav-server-tester probe gives
unsupportedwhen run against Robur; it is going into a PR there.